linux-kernel - Re: [PATCH] fs/fat: calculate checksum in a loop instead of directly calculating

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Feb 2015 04:25:54 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Alexander Kuleshov <kuleshovmail@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/fat: calculate checksum in a loop instead of directly calculating

Alexander Kuleshov <kuleshovmail@...il.com> writes:

>  static inline unsigned char fat_checksum(const __u8 *name)
>  {
> +	u8 i;
>  	unsigned char s = name[0];
> -	s = (s<<7) + (s>>1) + name[1];	s = (s<<7) + (s>>1) + name[2];
> -	s = (s<<7) + (s>>1) + name[3];	s = (s<<7) + (s>>1) + name[4];
> -	s = (s<<7) + (s>>1) + name[5];	s = (s<<7) + (s>>1) + name[6];
> -	s = (s<<7) + (s>>1) + name[7];	s = (s<<7) + (s>>1) + name[8];
> -	s = (s<<7) + (s>>1) + name[9];	s = (s<<7) + (s>>1) + name[10];
> +
> +	for (i = 1; i < 11; i++)
> +		s = (s << 7) + (s >> 1) + name[i];
> +
>  	return s;
>  }

When I wrote this, IIRC, there was measurable performance
difference. All major gcc versions are enough smart now to optimize this?
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/