linux-kernel - Re: [PATCH 1/1 linux-next] btrfs: fix sizeof format specifier in btrfs_check_super

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 22 Feb 2015 12:20:11 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Fabian Frederick <fabf@...net.be>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>,
	David Sterba <dsterba@...e.cz>,
	linux-btrfs <linux-btrfs@...r.kernel.org>
Subject: Re: [PATCH 1/1 linux-next] btrfs: fix sizeof format specifier in btrfs_check_super_valid()

On Sat, Feb 14, 2015 at 1:10 PM, Fabian Frederick <fabf@...net.be> wrote:
> This patch fixes mips compilation warning:

Actually it happens on all 32-bit platforms (where size_t is unsigned int).

> fs/btrfs/disk-io.c: In function 'btrfs_check_super_valid':
> fs/btrfs/disk-io.c:3927:21: warning: format '%lu' expects argument
> of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Wformat]
>
> Signed-off-by: Fabian Frederick <fabf@...net.be>

Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>

> ---
>  fs/btrfs/disk-io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index f79f385..639f266 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -3921,7 +3921,7 @@ static int btrfs_check_super_valid(struct btrfs_fs_info *fs_info,
>         }
>         if (btrfs_super_sys_array_size(sb) < sizeof(struct btrfs_disk_key)
>                         + sizeof(struct btrfs_chunk)) {
> -               printk(KERN_ERR "BTRFS: system chunk array too small %u < %lu\n",
> +               printk(KERN_ERR "BTRFS: system chunk array too small %u < %zu\n",
>                                 btrfs_super_sys_array_size(sb),
>                                 sizeof(struct btrfs_disk_key)
>                                 + sizeof(struct btrfs_chunk));

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/