linux-kernel - Re: Nokia N900: omap aes is broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Feb 2015 09:37:34 -0800
From:	Tony Lindgren <tony@...mide.com>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	Nishanth Menon <nm@...com>, Felipe Balbi <balbi@...com>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Sebastian Reichel <sre@...nel.org>,
	Pavel Machek <pavel@....cz>, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: Nokia N900: omap aes is broken

* Pali Rohár <pali.rohar@...il.com> [150224 09:42]:
> On Tuesday 24 February 2015 18:25:12 Tony Lindgren wrote:
> > * Pali Rohár <pali.rohar@...il.com> [150218 16:03]:
> > > --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> > > +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> > > @@ -3938,8 +3938,9 @@ int __init omap3xxx_hwmod_init(void)
> > > 
> > >  	if (r < 0)
> > >  	
> > >  		return r;
> > > 
> > > -	/* Register GP-only hwmod links. */
> > > -	if (h_gp && omap_type() == OMAP2_DEVICE_TYPE_GP) {
> > > +//	/* Register GP-only hwmod links. */
> > > +//	if (h_gp && omap_type() == OMAP2_DEVICE_TYPE_GP) {
> > > +	if (h_gp) {
> > > 
> > >  		r = omap_hwmod_register_links(h_gp);
> > >  		if (r < 0)
> > >  		
> > >  			return r;
> > > 
> > > aes hwmod is defined in GP-only hwmod...
> > 
> > Doesn't this depend on the bootloader version of n900 to work?
> > 
> > Regards,
> > 
> > Tony
> 
> Ok, it looks like second patch (omap_hwmod_3xxx_data.c) needs 
> that aes-enabled bootloader.

OK we need some runtime detection somehow for what's enabled..
 
> But first patch (omap3.dtsi) is needed for proper definitions. 
> Otherwise omap-aes driver will never work on DT systems.

Yeah that one makes sense to me, I guess you'll do a proper
fix for that one.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/