linux-kernel - Re: [PATCH] clk: divider: return real rate instead of divider value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Feb 2015 00:09:41 +0000
From:	James Hogan <james.hogan@...tec.com>
To:	Heiko Stübner <heiko@...ech.de>
Cc:	Mike Turquette <mturquette@...aro.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	LKML <linux-kernel@...r.kernel.org>,
	ARM Kernel List <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] clk: divider: return real rate instead of divider value

On 24 February 2015 at 10:39, Heiko Stübner <heiko@...ech.de> wrote:
> Commit bca9690b9426 ("clk: divider: Make generic for usage elsewhere")
> returned only the divider value for read-only dividers instead of the
> actual rate.
>
> Fixes: bca9690b9426 ("clk: divider: Make generic for usage elsewhere")
> Signed-off-by: Heiko Stuebner <heiko@...ech.de>

I just created an identical patch, so
Reviewed-by: James Hogan <james.hogan@...tec.com>
Tested-by: James Hogan <james.hogan@...tec.com>

Thanks
James

> ---
>  drivers/clk/clk-divider.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c
> index a213455..5b4c018 100644
> --- a/drivers/clk/clk-divider.c
> +++ b/drivers/clk/clk-divider.c
> @@ -355,7 +355,7 @@ static long clk_divider_round_rate(struct clk_hw *hw, unsigned long rate,
>                 bestdiv = readl(divider->reg) >> divider->shift;
>                 bestdiv &= div_mask(divider->width);
>                 bestdiv = _get_div(divider->table, bestdiv, divider->flags);
> -               return bestdiv;
> +               return DIV_ROUND_UP(*prate, bestdiv);
>         }
>
>         return divider_round_rate(hw, rate, prate, divider->table,
> --
> 2.1.4
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/