linux-kernel - Re: [PATCH 4/7] x86: entry.S: use JZ mnemonic after TEST, not JE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Feb 2015 07:16:28 -0800
From:	Andy Lutomirski <luto@...capital.net>
To:	Denys Vlasenko <vda.linux@...glemail.com>
Cc:	Borislav Petkov <bp@...en8.de>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ingo Molnar <mingo@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>, Oleg Nesterov <oleg@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Alexei Starovoitov <ast@...mgrid.com>,
	Will Drewry <wad@...omium.org>,
	Kees Cook <keescook@...omium.org>, X86 ML <x86@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/7] x86: entry.S: use JZ mnemonic after TEST, not JE

On Thu, Feb 26, 2015 at 6:13 AM, Denys Vlasenko
<vda.linux@...glemail.com> wrote:
> On Thu, Feb 26, 2015 at 12:04 AM, Borislav Petkov <bp@...en8.de> wrote:
>> On Wed, Feb 25, 2015 at 01:00:16AM +0100, Denys Vlasenko wrote:
>>> After TEST insn, JE actually performs "jump if zero",
>>> let's use JZ mnemonic instead.
>>>
>>> No code changes, but less confusion.
>>>
>>> Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
>>> CC: Linus Torvalds <torvalds@...ux-foundation.org>
>>> CC: Steven Rostedt <rostedt@...dmis.org>
>>> CC: Ingo Molnar <mingo@...nel.org>
>>> CC: Borislav Petkov <bp@...en8.de>
>>> CC: "H. Peter Anvin" <hpa@...or.com>
>>> CC: Andy Lutomirski <luto@...capital.net>
>>> CC: Oleg Nesterov <oleg@...hat.com>
>>> CC: Frederic Weisbecker <fweisbec@...il.com>
>>> CC: Alexei Starovoitov <ast@...mgrid.com>
>>> CC: Will Drewry <wad@...omium.org>
>>> CC: Kees Cook <keescook@...omium.org>
>>> CC: x86@...nel.org
>>> CC: linux-kernel@...r.kernel.org
>>> ---
>>>  arch/x86/kernel/entry_64.S | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Acked-by: Borislav Petkov <bp@...e.de>
>
> Andy, please don't take this patch yet, there are about a dozen
> more instances of TEST which need similar treatment.

I'm declaring a temporary moratorium on new development here until the
already-queued stuff is in -tip, looks okay, and we're in an
appropriate part of the cycle.  The series is already huge.

IOW I'm not applying this or the other pending patches yet.

--Andy

-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/