linux-kernel - Re: [PATCH v2] usb: isp1760: add peripheral/device controller chip id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Feb 2015 20:53:14 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Sudeep Holla <sudeep.holla@....com>
Cc:	Felipe Balbi <balbi@...com>, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v2] usb: isp1760: add peripheral/device controller chip id

Hi Sudeep,

Thank you for the patch.

On Thursday 26 February 2015 11:47:57 Sudeep Holla wrote:
> As per the SAF1761 data sheet[0], the DcChipID register represents
> the hardware version number (0001h) and the chip ID (1582h) for the
> Peripheral Controller.
> 
> However as per the ISP1761 data sheet[1], the DcChipID register
> represents the hardware version number (0015h) and the chip ID (8210h)
> for the Peripheral Controller.
> 
> This patch adds support for both the chip ID values.
> 
> [0] http://www.nxp.com/documents/data_sheet/SAF1761.pdf
> [1] http://pdf.datasheetcatalog.com/datasheets2/74/742102_1.pdf
> 
> Cc: Felipe Balbi <balbi@...com>
> Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@....com>

Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/usb/isp1760/isp1760-udc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Changes v1->v2:
>  - Updated to support both chip IDs: 0x00011582 and 0x00158210 instead of
>    just 0x00158210 as suggested by Laurent
> 
> diff --git a/drivers/usb/isp1760/isp1760-udc.c
> b/drivers/usb/isp1760/isp1760-udc.c index 9612d7990565..6d618b3fab07 100644
> --- a/drivers/usb/isp1760/isp1760-udc.c
> +++ b/drivers/usb/isp1760/isp1760-udc.c
> @@ -1411,7 +1411,7 @@ static int isp1760_udc_init(struct isp1760_udc *udc)
>  		return -ENODEV;
>  	}
> 
> -	if (chipid != 0x00011582) {
> +	if (chipid != 0x00011582 && chipid != 0x00158210) {
>  		dev_err(udc->isp->dev, "udc: invalid chip ID 0x%08x\n", chipid);
>  		return -ENODEV;
>  	}

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/