linux-kernel - RE: [PATCH] ACPI / EC: Remove non-standard log emphasis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Feb 2015 00:30:17 +0000
From:	"Zheng, Lv" <lv.zheng@...el.com>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Scot Doyle <lkml14@...tdoyle.com>
CC:	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ACPI / EC: Remove non-standard log emphasis

Hi,

> From: Rafael J. Wysocki [mailto:rjw@...ysocki.net]
> Sent: Thursday, February 26, 2015 6:56 AM
> 
> On Wednesday, February 25, 2015 03:01:08 PM Scot Doyle wrote:
> > On Wed, 25 Feb 2015, Zheng, Lv wrote:
> > ...
> > > > I was using "+++++"/"#####"/"*****" to filter different EC log entries which makes debugging easier.
> > > > And, if we changed this from pr_info into pr_debug, then we will have nothing in the suspend/resume logs for the EC device.
> > > > While there are plenty of such log entries for each of other devices.
> > > > So I really doubt what's the meaning of such a change.
> > > > Could it improve anything or just make debugging more difficult for developers?
> > >
> > > IMO, it's better to introduce such kind of code in the head of ec.c:
> > >
> > > #ifdef DEBUG_FILTER
> > > #define EC_LOG_DEV "+++++"
> > > #define EC_LOG_CMD "*****"
> > > #define EC_LOG_EVT "#####"
> > > ...
> > > #else
> > > #define EC_LOG_DEV
> > > #define EC_LOG_CMD
> > > #define EC_LOG_EVT
> > > #endif
> > >
> > > And wrap the pr_info, pr_debug using filter enabled new macros - ec_info, ec_debug so that we won't see the filters in the
> normal dmesg output and the filters are still available for the developers.
> > >
> > > Thanks and best regards
> > > -Lv
> >
> > I agree, would you be willing to submit it?
> 
> Yes, sounds good to me too!

OK. Let me try it and send the revised one after testing.

Thanks and best regards
-Lv

> 
> 
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.