linux-kernel - Re: [PATCH] f2fs: don't need to collect dirty sit entries and flush journal when there's no dirty sit entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 27 Feb 2015 16:54:45 +0800
From:	Wanpeng Li <wanpeng.li@...ux.intel.com>
To:	Jaegeuk Kim <jaegeuk@...nel.org>
Cc:	Changman Lee <cm224.lee@...sung.com>,
	linux-f2fs-devel@...ts.sourceforge.net,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Wanpeng Li <wanpeng.li@...ux.intel.com>
Subject: Re: [PATCH] f2fs: don't need to collect dirty sit entries and flush
 journal when there's no dirty sit entries

Please ignore this one which w/o patch description.
On Fri, Feb 27, 2015 at 04:49:37PM +0800, Wanpeng Li wrote:
>Signed-off-by: Wanpeng Li <wanpeng.li@...ux.intel.com>
>---
> fs/f2fs/segment.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
>index daee4ab..e7b83b6 100644
>--- a/fs/f2fs/segment.c
>+++ b/fs/f2fs/segment.c
>@@ -1730,6 +1730,9 @@ void flush_sit_entries(struct f2fs_sb_info *sbi, struct cp_control *cpc)
> 	mutex_lock(&curseg->curseg_mutex);
> 	mutex_lock(&sit_i->sentry_lock);
> 
>+	if (!sit_i->dirty_sentries)
>+		goto out;
>+
> 	/*
> 	 * add and account sit entries of dirty bitmap in sit entry
> 	 * set temporarily
>@@ -1744,9 +1747,6 @@ void flush_sit_entries(struct f2fs_sb_info *sbi, struct cp_control *cpc)
> 	if (!__has_cursum_space(sum, sit_i->dirty_sentries, SIT_JOURNAL))
> 		remove_sits_in_journal(sbi);
> 
>-	if (!sit_i->dirty_sentries)
>-		goto out;
>-
> 	/*
> 	 * there are two steps to flush sit entries:
> 	 * #1, flush sit entries to journal in current cold data summary block.
>-- 
>1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/