linux-kernel - Re: [PATCH 1/3] ocfs2: remove unneeded variable 'status'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Feb 2015 18:27:53 +0900
From:	DaeSeok Youn <daeseok.youn@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	mfasheh@...e.com, Joel Becker <jlbec@...lplan.org>,
	ocfs2-devel@....oracle.com,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] ocfs2: remove unneeded variable 'status'

Hi,

I think this patch was already queued. Can I send this patch again
after update changelog?

Thanks.

Regards,
Daeseok Youn

2015-02-27 6:33 GMT+09:00 Andrew Morton <akpm@...ux-foundation.org>:
> On Mon, 23 Feb 2015 19:38:10 +0900 Daeseok Youn <daeseok.youn@...il.com> wrote:
>
>> Use 'retval' instead of 'status'.
>>
>
> The patch does a lot more than this.  It causes __ocfs2_add_entry to
> propagate error codes which were previously dropped on the floor.
>
> Please update the changelog to fully explain the functional changes and
> to explain why they are desirable.
>
> After the patch there is still one unchecked call to
> ocfs2_journal_access_di() and one unchecked call to
> ocfs2_journal_access_db().  Probably these are bugs.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/