linux-kernel - Re: [PATCH 00/10] omap3 crypto fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Feb 2015 13:40:44 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Aaro Koskinen <aaro.koskinen@....fi>
Cc:	Benoît Cousson <bcousson@...libre.com>,
	Tony Lindgren <tony@...mide.com>,
	Rob Herring <robh+dt@...nel.org>,
	Russell King <linux@....linux.org.uk>,
	Paul Walmsley <paul@...an.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	Pavel Machek <pavel@....cz>, Nishanth Menon <nm@...com>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	Sebastian Reichel <sre@...nel.org>
Subject: Re: [PATCH 00/10] omap3 crypto fixes

On Thursday 26 February 2015 23:46:05 Aaro Koskinen wrote:
> Hi,
> 
> On Thu, Feb 26, 2015 at 02:49:50PM +0100, Pali Rohár wrote:
> > This patch series fix crypto support for omap3 devices which
> > use DT.
> > 
> > It enables AES and SHAM on N9/N950 and SHAM on N900. AES is
> > still disabled for N900.
> 
> (Please format your lines somewhere near < 76 chars,
> especially in commit logs, otherwise "git log" looks ugly on
> 80 char terminals.)
> 
> I tested these with stock bootloaders, and devices boot
> normally and I can now modprobe omap-aes (on N9 and N950) and
> omap-sham (on all three):
> 
> 	omap-aes 480c5000.aes: OMAP AES hw accel rev: 2.6
> 	omap-sham 480c3000.sham: hw accel on OMAP rev 0.9
> 
> However I get these when CONFIG_CRYPTO_MANAGER_DISABLE_TESTS
> is not set:
> 
> 	alg: hash: Chunking test 1 failed for omap-sha1
> 	alg: hash: Chunking test 1 failed for omap-md5
> 	alg: hash: Chunking test 1 failed for omap-hmac-sha1
> 	alg: hash: Chunking test 1 failed for omap-hmac-md5
> 
> But that's probably unrelated to this series. For patches 1-8,
> feel free to add:
> 
> Tested-by: Aaro Koskinen <aaro.koskinen@....fi>
> 
> A.

Hi, thanks for testing!

Now I'm happy that I can load omap-aes and omap-sham drivers on 
real n900 device, qemu n900 and after your tests also on real n9 
and n950 without any kernel crash or oops. Of course omap-aes is 
disabled on n900, but loading omap-aes.ko (accidentally) does not 
hurt.

It looks like there are other parts in md5 and sha broken, but 
first step is load & register all drivers without kernel crash. 
And this is working now.

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)