linux-kernel - Re: [PATCH 4/8] ARM OMAP2+ GPMC: change get_gpmc_timing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Feb 2015 17:23:40 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Robert Abel <rabel@...-ec.uni-bielefeld.de>
CC:	balbi@...com, Roger Quadros <rogerq@...com>,
	linux-omap@...r.kernel.org, linux-usb@...r.kernel.org,
	Linux Kernel Maling List <linux-kernel@...r.kernel.org>,
	Tony Lindgren <tony@...mide.com>, linux@....linux.org.uk
Subject: Re: [PATCH 4/8] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output
 for DTS

Hello.

On 2/27/2015 5:17 PM, Robert Abel wrote:

>>     Documentation/kernel-doc-nano-HOWTO.txt requires colons after the
>> parameter names, doesn't it?

> Jesus Christ, you guys are killing me...
> I've already spent way more time on this patch series than I intended
> to anyway...

    That's what you get when pushing your stuff upstream. You're not alone 
here. :-)

>>> +       mask = (1 << nr_bits) - 1;

>>     BIT(nr_bits) - 1, perhaps?

> Not happening... BIT macro obscures what's actually going on.

    I did search for a macro that does ((1 << n) - 1) but didn't found it, 
unfortunately...

> Regards,
> Robert

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/