linux-kernel - Re: [PATCH] usb/isp1760: set IRQ flags properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Feb 2015 16:48:39 +0100
From:	Valentin Rothberg <valentinrothberg@...il.com>
To:	balbi@...com
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	laurent.pinchart@...asonboard.com, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb/isp1760: set IRQ flags properly

On Fri, Feb 27, 2015 at 4:24 PM, Felipe Balbi <balbi@...com> wrote:
> On Fri, Feb 27, 2015 at 02:29:40PM +0100, Valentin Rothberg wrote:
>> The IRQF_DISABLED is a NOOP and scheduled to be removed.  According to
>> commit e58aa3d2d0cc (genirq: Run irq handlers with interrupts disabled)
>> running IRQ handlers with interrupts enabled can cause stack overflows
>> when the interrupt line of the issuing device is still active.
>>
>> This patch removes using this deprecated flag and additionally removes
>> redundantly setting IRQF_SHARED.
>
> why is it redundant ?

It's redundant in the call of isp1760_udc_register() as this function
sets the flag by requesting the IRQ.  I mistakenly removed it also in
the call of isp1760_hcd_register() which does not alter the passed
irqflags.  I will fix this in a second version of this patch.  I am
sorry for this mistake.

 Valentin

> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/