linux-kernel - Re: [PATCH] smp: Remove CSD_FLAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 27 Feb 2015 23:09:39 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Tim Chen <tim.c.chen@...ux.intel.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, Andi Kleen <andi@...stfloor.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Srivatsa S.Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] smp: Remove CSD_FLAG_WAIT flag that's unused

On Fri, Feb 27, 2015 at 12:36:13PM -0800, Tim Chen wrote:
> 
> The CSD_FLAG_WAIT is not serving any useful purpose as we do not use
> its value to decide if we are going to wait for a smp call to complete.
> We also never cleared it properly when we are done waiting to indicate
> that the wait is over.  So the WARNING debug check in csd_unlock is
> also not serving useful purpose.  Propose here to remove it to clean up
> the code.

Linus had a much more comprehensive patch:

  http://marc.info/?l=linux-kernel&m=142368734118230
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/