linux-kernel - Re: [PATCH v2] staging: lustre: fld_request.c: Remove else after return.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 1 Mar 2015 17:30:57 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Alberto Pires de Oliveira Neto <mrpenguin2005@...il.com>
Cc:	oleg.drokin@...el.com, andreas.dilger@...el.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: lustre: fld_request.c: Remove else after
 return.

On Sat, Feb 28, 2015 at 01:37:23PM -0300, Alberto Pires de Oliveira Neto wrote:
>     This patch fixes checkpatch.pl warning.
>     WARNING: else is not generally useful after a break or return
> 
> Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@...il.com>
> ---
>  drivers/staging/lustre/lustre/fld/fld_request.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/fld/fld_request.c b/drivers/staging/lustre/lustre/fld/fld_request.c
> index b8d17e1..0b00301 100644
> --- a/drivers/staging/lustre/lustre/fld/fld_request.c
> +++ b/drivers/staging/lustre/lustre/fld/fld_request.c
> @@ -217,10 +217,9 @@ int fld_client_add_target(struct lu_client_fld *fld,
>  		CERROR("%s: Attempt to add target %s (idx %llu) on fly - skip it\n",
>  			fld->lcf_name, name, tar->ft_idx);
>  		return 0;
> -	} else {
> -		CDEBUG(D_INFO, "%s: Adding target %s (idx %llu)\n",
> -		       fld->lcf_name, name, tar->ft_idx);
> -	}
> +	} 
> +	CDEBUG(D_INFO, "%s: Adding target %s (idx %llu)\n",
> +			fld->lcf_name, name, tar->ft_idx);
>  
>  	OBD_ALLOC_PTR(target);
>  	if (target == NULL)

Never add new checkpatch errors when trying to fix checkpatch errors, as
you will never end up removing them...

Please fix and resend.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/