linux-kernel - Re: [PATCH 2/3] remoteproc/davinci: fix quoted split string checkpatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Mar 2015 10:52:25 -0600
From:	Suman Anna <s-anna@...com>
To:	Joe Perches <joe@...ches.com>
CC:	Ohad Ben-Cohen <ohad@...ery.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] remoteproc/davinci: fix quoted split string checkpatch
 warning

On 02/27/2015 05:27 PM, Joe Perches wrote:
> On Fri, 2015-02-27 at 17:18 -0600, Suman Anna wrote:
>> Fix the following checkpatch warning,
>> WARNING: quoted string split across lines
>> +                "\n\t\tName of DSP firmware file in /lib/firmware"
>> +                " (if not specified defaults to 'rproc-dsp-fw')");
> []
>> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> []
>> @@ -26,8 +26,7 @@
>>  static char *da8xx_fw_name;
>>  module_param(da8xx_fw_name, charp, S_IRUGO);
>>  MODULE_PARM_DESC(da8xx_fw_name,
>> -		 "\n\t\tName of DSP firmware file in /lib/firmware"
>> -		 " (if not specified defaults to 'rproc-dsp-fw')");
>> +		 "\n\t\tName of DSP firmware file in /lib/firmware (if not specified defaults to 'rproc-dsp-fw')");
> 
> There's probably no value in the leading "\n\t\t"

Agreed.

Ohad,
Let me know if you want that in a different patch, otherwise, you can
probably fix this up when applying.

regards
Suman


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/