linux-kernel - Re: regcache_sync() errors for read-only registers cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Mar 2015 18:24:18 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: regcache_sync() errors for read-only registers cache

On Fri, Feb 27, 2015 at 01:59:30PM +0100, Takashi Iwai wrote:

> A quick fix is the patch like below, but obviously it doesn't cover
> the all cases but only addresses the signle rw.

Please don't bury patches in the middle of mails, that just means that
if the patch is useful it's painful to apply.  Your patch seems fine but
can you please resend in a directly applyable format unless something in
the below indicates against that...

> Also, _regmap_write() itself calls again regmap_writeable(), so it's
> superfluous.  Alternatively, we may check -EIO from _regmap_write()
> and treat as a special case not to show the error.  Or, add a
> parameter to skip regmap_writeable() call.

I'm sorry but I can't parse the above - what is "it" in this context?
Silently ignoring -EIO from the physical register write sounds like a
very bad idea though, that seems likely to discard actual errors.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)