linux-kernel - Re: [PATCH] kdb: Fix handling of kallsyms_symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 2 Mar 2015 21:25:43 -0600
From:	Jason Wessel <jason.wessel@...driver.com>
To:	Daniel Thompson <daniel.thompson@...aro.org>
CC:	<linux-kernel@...r.kernel.org>,
	<kgdb-bugreport@...ts.sourceforge.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...hat.com>, <patches@...aro.org>,
	<linaro-kernel@...ts.linaro.org>,
	John Stultz <john.stultz@...aro.org>,
	Sumit Semwal <sumit.semwal@...aro.org>
Subject: Re: [PATCH] kdb: Fix handling of kallsyms_symbol_next() return value

On 03/02/2015 08:13 AM, Daniel Thompson wrote:
> kallsyms_symbol_next() returns a boolean (true on success). Currently
> kdb_read() tests the return value with an inequality that
> unconditionally evaluates to true.
> 
> This is fixed in the obvious way and, since the conditional branch is
> supposed to be unreachable, we also add a WARN_ON().
> 


Thanks.  Applied to kgdb-next.  I'll send it along to the upstream
before the end of the v4.0 cycle, we'll see if we pickup any other
fixes along the way. :-)

Cheers,
Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/