linux-kernel - Re: [PATCH] checkkconfigsymbols.py: filter reports for tools/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 03 Mar 2015 01:57:08 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Valentin Rothberg <Valentin.Rothberg@...6.fr>
Cc:	gregkh@...uxfoundation.org, stefan.hengelein@....de,
	linux-kernel@...r.kernel.org, rupran@...server.de
Subject: Re: [PATCH] checkkconfigsymbols.py: filter reports for tools/

On Wed, 2015-02-25 at 15:15 +0100, Valentin Rothberg wrote:
> @@ -46,8 +46,9 @@ def main():
>          stdout = stdout[:-1]
>  
>      for gitfile in stdout.rsplit("\n"):
> -        if ".git" in gitfile or "ChangeLog" in gitfile or \
> -                ".log" in gitfile or os.path.isdir(gitfile):
> +        if ".git" in gitfile or "ChangeLog" in gitfile or      \
> +                ".log" in gitfile or os.path.isdir(gitfile) or \
> +                gitfile.startswith("tools/"):

Perhaps just
    gitfile == "tools/perf/config/Makefile"

(but I'm unsure if that's valid python)? 

>              continue
>          if REGEX_FILE_KCONFIG.match(gitfile):
>              kconfig_files.append(gitfile)

This patch was triggered by perf changes that hit next-20150225, wasn't
it? If so, we might want to find out why the perf people need to use
their
    "$(call detected,CONFIG_EXAMPLE)"

hack. Especially because that hack is also used on existing Kconfig
symbols (I spotted X86, X86_64, AUDIT, and NUMA). And the usage of both
valid Kconfig macros and faux Kconfig macros in that hack looks odd to
me.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/