linux-kernel - Re: [PATCH 10/38] perf tools: Pass session arg to perf_event__preprocess

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Mar 2015 23:18:41 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Jiri Olsa <jolsa@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Stephane Eranian <eranian@...gle.com>,
	Andi Kleen <andi@...stfloor.org>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 10/38] perf tools: Pass session arg to
 perf_event__preprocess_sample()

On Tue, Mar 03, 2015 at 10:59:30AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Mar 03, 2015 at 12:07:22PM +0900, Namhyung Kim escreveu:
> > The perf_event__preprocess_sample() translates a given ip into a
> > matching symbol.  To do that, it first finds a corresponding thread
> > and map in the current thread tree.  But for indexed data files, it
> > needs to find a thread (and map) with slightly different APIs using
> > timestamp.  So it needs a way to know whether this session deals with
> > an indexed data file or not.
> 
> I need to look into this, but in general, I'm trying to _remove_
> accesses to perf_session :-)

The reason is that it needs to know whether the current session has
index so that it's accessing the samples in sequence or in random
order.  If we can save that info at some other place (like a global
variable?) it doesn't need to pass session.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/