linux-kernel - Re: [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Mar 2015 18:21:45 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	christian.ruppert@...tech.com
Cc:	Alexey Brodkin <Alexey.Brodkin@...opsys.com>,
	"andriy.shevchenko@...ux.intel.com" 
	<andriy.shevchenko@...ux.intel.com>,
	"christian.ruppert@...lis.com" <christian.ruppert@...lis.com>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
	"Vineet.Gupta1@...opsys.com" <Vineet.Gupta1@...opsys.com>
Subject: Re: [PATCH] i2c: designware: Suppress error message if
 platform_get_irq() returns -EPROBE_DEFER


> which omit this type of messages completely. Andy's proposal of
> centralising this looks like a very good solution here (and on top of
> that removes many useless strings from the kernel binary).

I am all for centralizing printouts. I recommended this at my ELCE talk
last year, too. However, you need to keep in mind that irqs are
sometimes optional and you don't want error messages for those irqs.
IMO worthwhile, but not a low hanging fruit...


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)