linux-kernel - Re: [PATCH -next] net: i40e: fix build, depends on CONFIGFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 03 Mar 2015 15:02:07 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	rdunlap@...radead.org
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux.nics@...el.com, jeffrey.t.kirsher@...el.com
Subject: Re: [PATCH -next] net: i40e: fix build, depends on CONFIGFS_FS

From: Randy Dunlap <rdunlap@...radead.org>
Date: Tue, 03 Mar 2015 11:35:38 -0800

> From: Randy Dunlap <rdunlap@...radead.org>
> 
> i40e uses configfs interfaces so it should depend on CONFIGFS_FS.
> 
> Fixes these build errors:
> 
> drivers/built-in.o: In function `i40e_cfgfs_group_make_item':
> i40e_configfs.c:(.text+0x2fcdca): undefined reference to `config_item_init_type_name'
> drivers/built-in.o: In function `i40e_configfs_init':
> (.text+0x2fcee6): undefined reference to `config_group_init'
> drivers/built-in.o: In function `i40e_configfs_init':
> (.text+0x2fcf0c): undefined reference to `configfs_register_subsystem'
> drivers/built-in.o: In function `i40e_configfs_exit':
> (.text+0x2fcf71): undefined reference to `configfs_unregister_subsystem'
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Intel guys, I am furiously mad.

I've told you guys a thousand times to use portable, reasonable
mechanisms to configure your hardware.  Using facilities that can
be used for other cards from other vendors with similar facilities.

If such portable netdevice configuration frameworks do not exist,
create it.

Every time you make a device specific mechanism for configuration,
a small kitten dies somewhere in the world.

Please remove all of this configfs crap for twiddling bandwidth
et al. knobs, before I do it for you.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/