linux-kernel - Re: [PATCH v2] ASoC: Add support for NAU8824 codec to ASoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 04 Mar 2015 23:32:12 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Chih-Chiang Chang <ccchang12@...oton.com>
Cc:	Mark Brown <broonie@...nel.org>,
	"mcuos.com@...il.com" <mcuos.com@...il.com>,
	"tiwai@...e.de" <tiwai@...e.de>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	liam.r.girdwood@...el.com
Subject: Re: [PATCH v2] ASoC: Add support for NAU8824 codec to ASoC

Chih-Chiang Chang schreef op wo 04-03-2015 om 20:53 [+0800]:
> From fe37688e226f83ba477a3c2fbc1e64946cd4ec4e Mon Sep 17 00:00:00 2001
> From: Chih-Chiang Chang <ccchang12@...oton.com>
> Date: Wed, 4 Mar 2015 20:03:21 +0800
> Subject: [PATCH v2] ASoC: Add support for NAU8824 codec to ASoC

It seems that none of those lines were needed.

> --- /dev/null
> +++ b/include/sound/nau8824.h
> @@ -0,0 +1,22 @@
> +/*
> + * linux/sound/nau8824.h -- Platform data for NAU8824
> + *
> + * Copyright 2015 Nuvoton Technology Corp.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#ifndef __LINUX_SND_NAU8824_H
> +#define __LINUX_SND_NAU8824_H
> +
> +struct nau8824_platform_data {
> +       unsigned int audio_mclk1;
> +       unsigned int gpio_irq;
> +       int naudint_irq;
> +       int headset_detect;
> +       int button_press_detect;
> +};
> +
> +#endif

In the future something other than just sound/soc/codecs/nau8824.h is
going to include this header, right?

> --- /dev/null
> +++ b/sound/soc/codecs/nau8824.c
> @@ -0,0 +1,807 @@
> +/*
> + * linux/sound/soc/codecs/nau8824.c
> + *
> + * Copyright 2015 Nuvoton Technology Corp.
> + * Author: Meng-Huang Kuo <mhkuo@...oton.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */

This states the license is GPL v2. (So do the two headers this patch
adds.)

> +MODULE_LICENSE("GPL");

So that should probably be
    MODULE_LICENSE("GPL v2");


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/