linux-kernel - RE: [PATCH v4] x86: mce: kexec: switch MCE handler for kexec/kdump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Mar 2015 23:12:33 +0000
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
CC:	Borislav Petkov <bp@...en8.de>,
	Prarit Bhargava <prarit@...hat.com>,
	Vivek Goyal <vgoyal@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Junichi Nomura <j-nomura@...jp.nec.com>,
	Kiyoshi Ueda <k-ueda@...jp.nec.com>
Subject: RE: [PATCH v4] x86: mce: kexec: switch MCE handler for kexec/kdump

> - fixed AR and UC order in enum severity_level because UC is severer than AR
>  by definition. Current code is not affected by this wrong order by chance.

AR and AO are both UC errors - that happen also to be recoverable.  Are you really sure
about this re-order not affecting existing code?  You might well be right, but as every one
else has pointed out mce_severity() is full of odd subtleties that catch people out.

Is the "UC" entry at the end of the severities[] table just a catch-all for things that made it
past all the other entries? Does it ever really get used?

What was the test case that made you promote UC above AR?

This absolutely should not be buried in the middle of your other patch - it needs to
be separate with a much more than two lines of commit description.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/