linux-kernel - Re: [PATCH 1/4] usb: phy: twl4030: make runtime pm more reliable.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Mar 2015 17:24:59 +1100
From:	NeilBrown <neilb@...e.de>
To:	Pavel Machek <pavel@....cz>
Cc:	Tony Lindgren <tony@...mide.com>, Felipe Balbi <balbi@...com>,
	Kishon Vijay Abraham I <kishon@...com>,
	linux-omap@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>,
	GTA04 owners <gta04-owner@...delico.com>
Subject: Re: [PATCH 1/4] usb: phy: twl4030: make runtime pm more reliable.

On Mon, 2 Mar 2015 22:03:59 +0100 Pavel Machek <pavel@....cz> wrote:

> Hi!
> 
> > +		status_changed =
> > +			(twl->linkstat == OMAP_MUSB_VBUS_VALID ||
> > +			 twl->linkstat == OMAP_MUSB_ID_GROUND)
> > +			!=
> > +			(status == OMAP_MUSB_VBUS_VALID ||
> > +			 status == OMAP_MUSB_ID_GROUND);
> >  		twl->linkstat = status;
> ...
> > @@ -768,6 +770,10 @@ static int twl4030_usb_remove(struct platform_device *pdev)
> >  
> >  	/* disable complete OTG block */
> >  	twl4030_usb_clear_bits(twl, POWER_CTRL, POWER_CTRL_OTG_ENAB);
> > +
> > +	if (twl->linkstat == OMAP_MUSB_VBUS_VALID ||
> > +	    twl->linkstat == OMAP_MUSB_ID_GROUND)
> > +		pm_runtime_put_noidle(twl->dev);
> >  	pm_runtime_mark_last_busy(twl->dev);
> 
> inline function returning (x == OMAP_MUSB_VBUS_VALID || x ==
> OMAP_MUSB_ID_GROUND) would really help readability here.
> 
> Thanks,
> 									Pavel

Good idea.  I've done that.  The function is called "cable_present()".

Thanks,
NeilBrown

Content of type "application/pgp-signature" skipped