linux-kernel - Re: [PATCH 1/2] phy: miphy28lp: Convert to devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Mar 2015 10:00:17 +0100
From:	Gabriel Fernandez <gabriel.fernandez@...com>
To:	Axel Lin <axel.lin@...ics.com>,
	Kishon Vijay Abraham I <kishon@...com>
CC:	"kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Alexandre Torgue <alexandre.torgue@...com>
Subject: Re: [PATCH 1/2] phy: miphy28lp: Convert to devm_kcalloc and fix wrong
 sizof

Acked-by: Gabriel Fernandez<gabriel.fernandez@...aro.org>


On 03/05/2015 02:43 AM, Axel Lin wrote:
> Prefer devm_kcalloc over devm_kzalloc with multiply.
> In additional, use sizeof(phy) is incorrect, fix it.
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
> This patch is on top of below patch:
> [PATCH 1/2] phy: miphy28lp: Avoid calling of_get_child_count() multiple times
>
>   drivers/phy/phy-miphy28lp.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/phy/phy-miphy28lp.c b/drivers/phy/phy-miphy28lp.c
> index 4fe1755..9334352 100644
> --- a/drivers/phy/phy-miphy28lp.c
> +++ b/drivers/phy/phy-miphy28lp.c
> @@ -1209,9 +1209,8 @@ static int miphy28lp_probe(struct platform_device *pdev)
>   		return -ENOMEM;
>   
>   	miphy_dev->nphys = of_get_child_count(np);
> -	miphy_dev->phys = devm_kzalloc(&pdev->dev,
> -				       sizeof(phy) * miphy_dev->nphys,
> -				       GFP_KERNEL);
> +	miphy_dev->phys = devm_kcalloc(&pdev->dev, miphy_dev->nphys,
> +				       sizeof(*miphy_dev->phys), GFP_KERNEL);
>   	if (!miphy_dev->phys)
>   		return -ENOMEM;
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/