linux-kernel - Re: [PATCH] Staging: rtl8192u: r8190_rtl8256: coding style and format string type connections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 6 Mar 2015 16:54:55 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Tolga Ceylan <tolga.ceylan@...il.com>
Cc:	Sanjeev Sharma <sanjeev_sharma@...tor.com>,
	Loïc Pellegrino <oort10@...il.com>,
	Mohammad Jamal <md.jamalmohiuddin@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8192u: r8190_rtl8256: coding style and
 format string type connections

On Sun, Feb 08, 2015 at 08:46:28PM -0800, Tolga Ceylan wrote:
> Lines over 80 were corrected
> RT_TRACE format strings should specify unsigned instead of signed int

I don't understand, why did you do 2 different things in a single patch?

Please split this up.

Also:

>  		case RF90_PATH_C:
> -			u4RegValue = rtl8192_QueryBBReg(dev, pPhyReg->rfintfs, bRFSI_RFENV);
> +			u4RegValue = rtl8192_QueryBBReg(dev, pPhyReg->rfintfs,
> +				bRFSI_RFENV);

Please indent this to the character after '(' on the line above.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/