linux-kernel - Re: [PATCH] staging/lustre: Make lstcon_console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 7 Mar 2015 18:43:56 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Peter Senna Tschudin <peter.senna@...il.com>
Cc:	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Luca Ceresoli <luca@...aceresoli.net>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	Heena Sirwani <heenasirwani@...il.com>,
	Vitaly Osipov <vitaly.osipov@...il.com>,
	Asaf Vertz <asaf.vertz@...demg.com>,
	Himangi Saraogi <himangi774@...il.com>,
	Greg Donald <gdonald@...il.com>, Joe Perches <joe@...ches.com>,
	HPDD-discuss@...ts.01.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/lustre: Make lstcon_console_{init,fini} static

On Sat, Mar 07, 2015 at 12:41:06PM +0100, Peter Senna Tschudin wrote:
> sparse was complaining that the symbols 'lstcon_console_init'
> and 'lstcon_console_fini' were not declared.
> 
> Declaring both as static.

you have not even build tested your patch.

WARNING: "lstcon_console_init" [drivers/staging/lustre/lnet/selftest/lnet_selftest.ko] undefined!
WARNING: "lstcon_console_fini" [drivers/staging/lustre/lnet/selftest/lnet_selftest.ko] undefined!

both of them are being used in selftest/module.c


regards
sudip
> 
> Signed-off-by: Peter Senna Tschudin <peter.senna@...il.com>
> ---
>  drivers/staging/lustre/lnet/selftest/console.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c
> index 1e0afc2..6d62c48 100644
> --- a/drivers/staging/lustre/lnet/selftest/console.c
> +++ b/drivers/staging/lustre/lnet/selftest/console.c
> @@ -1989,8 +1989,7 @@ extern int lstcon_ioctl_entry(unsigned int cmd, struct libcfs_ioctl_data *data);
>  static DECLARE_IOCTL_HANDLER(lstcon_ioctl_handler, lstcon_ioctl_entry);
>  
>  /* initialize console */
> -int
> -lstcon_console_init(void)
> +static int lstcon_console_init(void)
>  {
>  	int     i;
>  	int     rc;
> @@ -2059,8 +2058,7 @@ out:
>  	return rc;
>  }
>  
> -int
> -lstcon_console_fini(void)
> +static int lstcon_console_fini(void)
>  {
>  	int     i;
>  
> -- 
> 2.1.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/