linux-kernel - Re: [PATCH v10 0/2] drivers/gpio: Altera soft IP GPIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 7 Mar 2015 20:35:59 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Tien Hock Loh <thloh@...era.com>
Cc:	Dinh Nguyen <dinguyen@...era.com>,
	Rob Herring <robh+dt@...nel.org>,
	Paweł Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	Greg KH <gregkh@...uxfoundation.org>,
	Joe Perches <joe@...ches.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Antti Palosaari <crope@....fi>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Tien Hock Loh <thloh.linux@...il.com>
Subject: Re: [PATCH v10 0/2] drivers/gpio: Altera soft IP GPIO driver

On Tue, Feb 24, 2015 at 10:53 AM,  <thloh@...era.com> wrote:

> From: Tien Hock Loh <thloh@...era.com>
>
> Adds a new device tree binding and driver for Altera soft GPIO IP.
> The driver is able to do read/write and allows GPIO to be a interrupt controller.
>
> Tested on Altera GHRD on interrupt handling and IO.
>
> v10:
> Updated conflicting device tree parameters
> Removed unused headers
> Used macro instead of magic numbers for ngpio
> Code readability cleanup using ?: and temporal variables
> Removed leftover garbage and unnecessary function calls
> Checked bgpio_init but unusable because Altera GPIO may not be a multiple of 8 bits

This v10 patch applied. Any remaining issues can certainly be resolved
by additional patches in-tree.

Good patience and good work, the driver looks really really neat now.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/