linux-kernel - Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Mar 2015 18:06:33 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Lorenzo Stoakes <lstoakes@...il.com>, teddy.wang@...iconmotion.com,
	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750

On Tue, Mar 10, 2015 at 02:40:30PM +0300, Dan Carpenter wrote:
> On Tue, Mar 10, 2015 at 09:57:06AM +0000, Lorenzo Stoakes wrote:
> > This patch assigns the more appropriate void* type to the mmio750 variable
> > eliminating an unnecessary volatile qualifier in the process. Additionally it
> > updates parameter types as necessary where those parameters interact with
> > mmio750 and removes unnecessary casts.
> > 
> > As a consequence, this patch fixes the following sparse warning:-
> > 
> > drivers/staging/sm750fb/ddk750_help.c:12:17: warning: incorrect type in assignment (different address spaces)
> > 
> > Signed-off-by: Lorenzo Stoakes <lstoakes@...il.com>
> 
> Looks good.  Thanks for doing this.

but it is introducing two new build warnings:

drivers/staging/sm750fb/sm750_hw.c: In function ‘hw_sm750_map’:
drivers/staging/sm750fb/sm750_hw.c:67:2: warning: passing argument 1 of ‘ddk750_set_mmio’ discards ‘volatile’ qualifier from pointer target type [enabled by default]
In file included from drivers/staging/sm750fb/ddk750_mode.h:4:0,
                    from drivers/staging/sm750fb/ddk750.h:15,
                    from drivers/staging/sm750fb/sm750_hw.c:24:

and

drivers/staging/sm750fb/ddk750_chip.h:77:6: note: expected ‘void *’ but argument is of type ‘volatile unsigned char *’

care to make another patch to solve these two new warnings, and send this patch and the new one in a series and while sending mark the version number in the subject.

regards
sudip
> 
> regards,
> dan carpenter
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/