linux-kernel - Re: [PATCH] kernfs: remove outdated and confusing comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150311114531.GB25944@htj.duckdns.org>
Date:	Wed, 11 Mar 2015 07:45:31 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Wolfram Sang <wsa@...-dreams.de>
Cc:	linux-kernel@...r.kernel.org, linux-sh@...r.kernel.org
Subject: Re: [PATCH] kernfs: remove outdated and confusing comment

On Wed, Mar 11, 2015 at 11:26:02AM +0100, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@...g-engineering.com>
> 
> Grabbing the parent is not happening anymore since 2010 (e72ceb8ccac5f7
> "sysfs: Remove sysfs_get/put_active_two"). Remove this confusing
> comment.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

Acked-by: Tejun Heo <tj@...nel.org>

> Found while trying to find out why my sysfs-bin file always returns POLLPRI
> after opening, reading, polling. Any pointers while I am here? :)

Hmm... poll isn't hooked up for bin files and the behavior isn't well
defined either.  The open file's event counter is never synchronized
to the backing node's.  Before the first kernfs_notify(), it won't
trigger and after always.  We'll prolly need to define that better.
What's the use case that you're interested in?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/