linux-kernel - Re: [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Mar 2015 16:47:06 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Wang Long <long.wanglong@...wei.com>
Cc:	Anton Vorontsov <anton@...msg.org>,
	Colin Cross <ccross@...roid.com>,
	Tony Luck <tony.luck@...el.com>,
	LKML <linux-kernel@...r.kernel.org>,
	peifeiyue <peifeiyue@...wei.com>, morgan.wang@...wei.com
Subject: Re: [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update

On Mon, Mar 9, 2015 at 12:39 AM, Wang Long <long.wanglong@...wei.com> wrote:
> In the function ramoops_probe, the console_size, pmsg_size,
> ftrace_size may be update because the value is not the power
> of two. We should update the module parameter variables
> as well so they are visible through /sys/module/ramoops/parameters
> correctly.
>
> Signed-off-by: Wang Long <long.wanglong@...wei.com>
> ---
>  fs/pstore/ram.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 5df325e..1aaa8dc 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -559,6 +559,9 @@ pr_info("[%s] pstore_register", __func__);
>         mem_address = pdata->mem_address;
>         record_size = pdata->record_size;
>         dump_oops = pdata->dump_oops;
> +       ramoops_console_size = pdata->console_size;
> +       ramoops_pmsg_size = pdata->pmsg_size;
> +       ramoops_ftrace_size = pdata->ftrace_size;
>
>         pr_info("attached 0x%lx@...llx, ecc: %d/%d\n",
>                 cxt->size, (unsigned long long)cxt->phys_addr,

I swear this had been fixed before. Thanks for catching it!

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

> --
> 1.8.3.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/