linux-kernel - [PATCH 0/1] x86/cpu: kill eager_fpu_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 14 Mar 2015 16:13:08 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	Borislav Petkov <bp@...e.de>
Cc:	Dave Hansen <dave.hansen@...el.com>,
	Ingo Molnar <mingo@...nel.org>,
	Andy Lutomirski <luto@...capital.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Pekka Riikonen <priikone@....fi>,
	Rik van Riel <riel@...hat.com>,
	Suresh Siddha <sbsiddha@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"Yu, Fenghua" <fenghua.yu@...el.com>,
	Quentin Casasnovas <quentin.casasnovas@...cle.com>
Subject: [PATCH 0/1] x86/cpu: kill eager_fpu_init_bp()

On 03/14, Borislav Petkov wrote:
>
> On Fri, Mar 13, 2015 at 07:26:56PM +0100, Oleg Nesterov wrote:
> > Hello.
> >
> > This patch is "out of order" a bit, but since Borislav mentioned this
> > during review...
> >
> > And I was going to send the 2nd one (below), but it turns out that
> > __init_refok is not discarded? So is there any way to do
> >
> > 	void __init init_function();
> >
> > 	void non_init_func()
> > 	{
> > 		if (can_only_be_true_before_free_initmem)
> > 			init_function();
> > 	}
> >
> > and avoid the warning?

It turns out I _completely_ misunderstood __init_refok.

> Actually, I was wondering if we could be even more radical and do
> the boot cpu-specific stuff only in the BSP boot path.

Yes, yes, agreed. This needs more changes, but imo this would be a nice
cleanup.

Still. I think it makes sense to kill eager_fpu_init_bp() right now, this
won'r complicate the mentioned cleanups.

On top of  "x86/fpu: don't allocate fpu->state for swapper/0".

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/