linux-kernel - Re: [PATCH 09/13] VFS/namei: enable RCU-walk when following symlinks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Mar 2015 22:44:28 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	NeilBrown <neilb@...e.de>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/13] VFS/namei: enable RCU-walk when following symlinks.

On Mon, Mar 16, 2015 at 03:43:20PM +1100, NeilBrown wrote:
>  	if (should_follow_link(path->dentry, follow)) {
> -		if (nd->flags & LOOKUP_RCU) {
> -			if (unlikely(unlazy_walk(nd, path->dentry))) {
> -				err = -ECHILD;
> -				goto out_err;
> -			}
> -		}
>  		BUG_ON(inode != path->dentry->d_inode);

... and now this BUG_ON() can bloody well be triggered.
>  	if (should_follow_link(path->dentry, !symlink_ok)) {
> -		if (nd->flags & LOOKUP_RCU) {
> -			if (unlikely(unlazy_walk(nd, path->dentry))) {
> -				error = -ECHILD;
> -				goto out;
> -			}
> -		}
>  		BUG_ON(inode != path->dentry->d_inode);

So can this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/