linux-kernel - Re: Possible no longer required cast in the function,usbhs_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 17 Mar 2015 08:51:28 +0100
From:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:	Peter Chen <Peter.Chen@...escale.com>
Cc:	nick <xerofoify@...il.com>, "balbi@...com" <balbi@...com>,
	"ergei.shtylyov@...entembedded.com" 
	<ergei.shtylyov@...entembedded.com>,
	"varkab@...c.in" <varkab@...c.in>,
	"yoshihiro.shimoda.uh@...esas.com" <yoshihiro.shimoda.uh@...esas.com>,
	"ulrich.hecht@...il.com" <ulrich.hecht@...il.com>,
	"takeshi.kihara.df@...esas.com" <takeshi.kihara.df@...esas.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: Possible  no longer required cast in the function,usbhs_parse_dt
 in common.c

On Tue, Mar 17, 2015 at 03:37:42AM +0000, Peter Chen wrote:
>  
> > 
> > Greetings All,
> > I have been getting the below build warnings:
> > drivers/usb/renesas_usbhs/common.c: In function ‘usbhs_parse_dt’:
> > drivers/usb/renesas_usbhs/common.c:482:25: warning: cast from pointer to
> > integer of different size [-Wpointer-to-int-cast]
> > dparam->type = of_id ? (u32)of_id->data : 0;
> > After looking into the function I am curious if the hardware is only 32 bit as if
> > the supported hardware for this driver is then this cast is no longer required
> > and I can send in a patch removing it. Furthermore, sorry for the simple
> > question but  I don't have access to the device specs for supported hardware
> > so I though it would be better to ask before I send in patch fixing this issue.
> > Thanks,
> > Nick
> 
> Patch is welcome, there will be comment if it is not suitable.

Sorry, but no, a patch is not welcome from Nick.  You all will note that
Nick is banned from vger.kernel.org and I would recommend that everyone
else on the cc: here also add him to their kill-files.  It will make
your life much easier.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/