lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 17 Mar 2015 20:55:55 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Xie XiuQi <xiexiuqi@...wei.com>
Cc:	Tony Luck <tony.luck@...il.com>,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	Chen Gong <gong.chen@...ux.intel.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"Borislav Petkov" <bp@...e.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>, <jingle.chen@...wei.com>
Subject: Re: [PATCH] tracing: add trace event for memory-failure

On Tue, 17 Mar 2015 18:47:40 +0800
Xie XiuQi <xiexiuqi@...wei.com> wrote:

> I'm not clearly why we need a hard coded here. As the strings or "result" have
> defined in mm/memory-failure.c, so passing "action_name[result]" would be more
> clean and more flexible here?

The TP_printk() is what will be shown in the print format of the event
"format" file, and is what trace-cmd and perf use to parse the data and
know what to print. If you use "action_name[result]" that will be what
the user space tools see, and will have no idea what to do with
"action_name[result]". The hard coded output is a bit more explicit in
how to interpret the raw data.

Another way around this is to create a "plugin" that can be loaded and
will override the TP_printk() parsing.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ