linux-kernel - Re: [PATCH octeon-usb] fix 'line over 80 characters'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Mar 2015 15:53:40 +0100
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Amitoj Kaur Chawla <amitoj1606@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH octeon-usb] fix 'line over 80 characters'

On Wed, Mar 18, 2015 at 08:12:32PM +0530, Amitoj Kaur Chawla wrote:
> 
> This file contained a warning of a line being over 80 characters and
> so the file has been edited to remove that warning.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>


Why did you put the driver name within the []?  It needs to go outside
of it.

> ---
>  drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 1daeb31..c8df0c3 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -2884,7 +2884,7 @@ static int __cvmx_usb_poll_channel(struct cvmx_usb_state *usb, int channel)
>  				pipe->pid_toggle = 1;
>  				if (__cvmx_usb_pipe_needs_split(usb, pipe))
>  					transaction->stage =
> -						CVMX_USB_STAGE_SETUP_SPLIT_COMPLETE;
> +					CVMX_USB_STAGE_SETUP_SPLIT_COMPLETE;

This really doesn't help much, the original code is fine, there are
better things to fix in this file :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/