linux-kernel - Re: dm log userspace: use mempool_create_kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Mar 2015 18:30:46 -0400
From:	Mike Snitzer <snitzer@...hat.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Alasdair Kergon <agk@...hat.com>, Neil Brown <neilb@...e.de>,
	linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org,
	dm-devel@...hat.com
Subject: Re: dm log userspace: use mempool_create_kmalloc_pool()

On Wed, Mar 11 2015 at  8:58am -0400,
Mike Snitzer <snitzer@...hat.com> wrote:

> On Sat, Mar 07 2015 at  7:43pm -0500,
> David Rientjes <rientjes@...gle.com> wrote:
> 
> > Mempools created for kmalloc caches should use
> > mempool_create_kmalloc_pool().
> > 
> > Cc: Alasdair Kergon <agk@...hat.com>
> > Cc: Mike Snitzer <snitzer@...hat.com>
> > Cc: Neil Brown <neilb@...e.de>
> > Signed-off-by: David Rientjes <rientjes@...gle.com>
> 
> Thanks David, I'll get this queued up.

Turns out I already fixed this a different way about a month ago and
staged it for 4.1, see:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=db57216e710ea5c517f1030fafe7eb21ac938dc5

You'll be interested to note this portion of that commit's header:
"This _should_ eliminate DM's need for io_schedule_timeout() in
mempool_alloc(); so io_schedule() should be sufficient now."

I'll defer to you on whether you'd like to pursue switching to
io_schedule() in mempool_alloc().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/