| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 Mar 2015 16:07:27 -0700 From: Sam Bradshaw <sbradshaw@...ron.com> To: Jens Axboe <axboe@...nel.dk> CC: <linux-kernel@...r.kernel.org> Subject: [PATCH v2] blkmq: Fix NULL pointer deref when all reserved tags in use When allocating from the reserved tags pool, bt_get() is called with a NULL hctx. If all tags are in use, the hw queue is kicked to push out any pending IO, potentially freeing tags, and tag allocation is retried. The problem is that blk_mq_run_hw_queue() doesn't check for a NULL hctx. So we avoid it with a simple NULL hctx test. This issue was introduced by: b32232073e80: blk-mq: fix hang in bt_get() Tested by hammering mtip32xx with concurrent smartctl/hdparm. Signed-off-by: Sam Bradshaw <sbradshaw@...ron.com> Signed-off-by: Selvan Mani <smani@...ron.com> --- diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c index d53a764..9d7dd64 100644 --- a/block/blk-mq-tag.c +++ b/block/blk-mq-tag.c @@ -280,7 +280,8 @@ static int bt_get(struct blk_mq_alloc_data *data, * pending IO submits before going to sleep waiting for * some to complete. */ - blk_mq_run_hw_queue(hctx, false); + if (hctx) + blk_mq_run_hw_queue(hctx, false); /* * Retry tag allocation after running the hardware queue, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists