linux-kernel - Re: [PATCH] mac802154: fix typo in header guard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Mar 2015 21:59:47 +0800
From:	Nicolas Iooss <nicolas.iooss_linux@....org>
To:	Paul Bolle <pebolle@...cali.nl>,
	Alexander Aring <alex.aring@...il.com>
CC:	linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, marcel@...tmann.org
Subject: Re: [PATCH] mac802154: fix typo in header guard

On 03/19/2015 09:46 PM, Paul Bolle wrote:
> On Thu, 2015-03-19 at 14:37 +0100, Alexander Aring wrote:
>> On Thu, Mar 19, 2015 at 09:23:40PM +0800, Nicolas Iooss wrote:
>>> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@....org>
>>> Fixes: b6eea9ca354a ("mac802154: introduce driver-ops header")
>>
>> Acked-by: Alexander Aring <alex.aring@...il.com>
>>
>> can you please queue this into bluetooth-next or even bluetooth?
> 
> Is the Fixes: tag needed?
> 
> mac802154.ko builds fine on my machine. There's also no error or warning
> included in the commit explanation. So it seems this is just a typo fix,
> not something that should be sent to stable too. Or did I miss something
> non-obvious?

No, you didn't miss anything.  It is only a fix for a typo I found while
testing LLVMLinux (clang warns about such typos with -Wheader-guard).

I added a Fixes: tag because it is easier to remove it afterwards that
to search for a commit when adding it.  I think this patch should not be
sent to stable@, and feel free to remove the tag if for you it means
"forward to stable@" (Documentation/SubmittingPatches is not clear about
whether a Fixes tag should be only used for real bugs or if it also
applies to compiler warnings).

Thanks for your quick replies.

Nicolas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/