linux-kernel - Re: [Ocfs2-devel] [PATCH 2/4 RESEND] ocfs2: remove extra mlog_errno() call in __ocfs2_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 Mar 2015 11:30:07 +0900
From:	DaeSeok Youn <daeseok.youn@...il.com>
To:	Joseph Qi <joseph.qi@...wei.com>
Cc:	mfasheh@...e.com, Andrew Morton <akpm@...ux-foundation.org>,
	"ocfs2-devel@....oracle.com" <ocfs2-devel@....oracle.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [Ocfs2-devel] [PATCH 2/4 RESEND] ocfs2: remove extra mlog_errno()
 call in __ocfs2_add_entry()

OK.

If i want to clean up mlog() call twice, mlog() in " bail" can be
removed, right?

Thanks.
Regards,
Daeseok Youn

2015-03-19 19:45 GMT+09:00 Joseph Qi <joseph.qi@...wei.com>:
> On 2015/2/28 7:49, Daeseok Youn wrote:
>> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
>> ---
>> RESEND: this patch is rebased by 1/4
>>
>>  fs/ocfs2/dir.c |    8 ++------
>>  1 files changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
>> index 1478a50..c1ab24f 100644
>> --- a/fs/ocfs2/dir.c
>> +++ b/fs/ocfs2/dir.c
>> @@ -1689,10 +1689,8 @@ int __ocfs2_add_entry(handle_t *handle,
>>               if (ocfs2_dirent_would_fit(de, rec_len)) {
>>                       dir->i_mtime = dir->i_ctime = CURRENT_TIME;
>>                       retval = ocfs2_mark_inode_dirty(handle, dir, parent_fe_bh);
>> -                     if (retval < 0) {
>> -                             mlog_errno(retval);
>> +                     if (retval < 0)
>>                               goto bail;
>> -                     }
>>
>>                       if (insert_bh == parent_fe_bh)
>>                               retval = ocfs2_journal_access_di(handle,
>> @@ -1709,10 +1707,8 @@ int __ocfs2_add_entry(handle_t *handle,
>>                                       retval = ocfs2_dx_dir_insert(dir,
>>                                                               handle,
>>                                                               lookup);
>> -                                     if (retval) {
>> -                                             mlog_errno(retval);
>> +                                     if (retval)
>>                                               goto bail;
>> -                                     }
>>                               }
>>                       }
>>
>>
> IMO, these two mlogs are not "extra" because we can directly know the
> cause if error occurs.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/