| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Mar 2015 13:21:43 -0600 From: Jens Axboe <axboe@...nel.dk> To: Jeff Moyer <jmoyer@...hat.com> CC: Tejun Heo <tj@...nel.org>, kent.overstreet@...il.com, Benjamin LaHaise <bcrl@...ck.org>, linux-kernel@...r.kernel.org Subject: Re: serial percpu_ref draining in exit_aio() On 03/20/2015 12:56 PM, Jeff Moyer wrote: > Jens Axboe <axboe@...nel.dk> writes: > >> On 03/19/2015 03:27 PM, Jens Axboe wrote: >>> On 03/19/2015 03:00 PM, Tejun Heo wrote: >>>> On Thu, Mar 19, 2015 at 04:58:33PM -0400, Jeff Moyer wrote: >>>>> Do you really want to do memory allocation in the exit path? That >>>>> sounds like a bad idea to me. (Of course, now you're going to point out >>>>> all the places that currently happens, right? ;-) >>>> >>>> I think we just need a counter there - let everyone count down as they >>>> exit and the last one trigger the completion, no? >>> >>> Yeah that's a good point, that'd be cleaner too. I'll change it and test >>> that. >> >> Here's a cleaner variant that pairs the completion even with an atomic >> count. Works for me as well. > > I like this version. I ran it though the libaio test harness and > xfstests aio tests and it passed. > > Thanks, Jens! > > Reviewed-by: Jeff Moyer <jmoyer@...hat.com> Thanks for testing, Jeff! I'll send out a proper patch with your reviewed-by as well. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists