linux-kernel - Re: [PATCH 1/1 linux-next] fanotify: fix a lock in fanotify_should_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 21 Mar 2015 02:15:17 +0100
From:	Lino Sanfilippo <LinoSanfilippo@....de>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Fabian Frederick <fabf@...net.be>
CC:	linux-kernel@...r.kernel.org, Jan Kara <jack@...e.cz>,
	David Howells <dhowells@...hat.com>,
	Eric Paris <eparis@...hat.com>
Subject: Re: [PATCH 1/1 linux-next] fanotify: fix a lock in fanotify_should_send_event()

On 21.03.2015 02:01, Lino Sanfilippo wrote:

>> Should that be (marks_mask & FS_ISDIR & marks_ignored_mask)?
>> 
> 
> No, the current logic should be correct, since we want events for
> directories if we have FS_ISDIR set in the marks mask but not in its
> ignored_mask.
> 

Actually this should be: "... since we ONLY want events for directories
if we have FS_ISDIR set in the marks mask but not in its ignored_mask".

With Fabians Code we could even get events for dirs although FAN_ONDIR
has not been set - which is not what we want.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/