linux-kernel - Re: [PATCH v3 2/5] input: synaptics - change default width value of cr48 sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Mar 2015 16:48:15 -0400
From:	Benjamin Tissoires <benjamin.tissoires@...il.com>
To:	Gabriele Mazzotta <gabriele.mzt@...il.com>
Cc:	linux-input <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Henrik Rydberg <rydberg@...math.org>,
	Maxwell Anselm <silverhammermba@...il.com>,
	Peter Hutterer <peter.hutterer@...-t.net>,
	Hans de Goede <hdegoede@...hat.com>, grafi@...fi.jp,
	Oliver Neukum <oneukum@...e.de>
Subject: Re: [PATCH v3 2/5] input: synaptics - change default width value of
 cr48 sensors

On Sun, Mar 22, 2015 at 10:43 AM, Gabriele Mazzotta
<gabriele.mzt@...il.com> wrote:
> The minimum value these sensors can report is 4, so this should be the
> value used when W is not reporting the width.
>
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@...il.com>
> ---
>  drivers/input/mouse/synaptics.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 133e488..a7a0e73 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -1018,7 +1018,7 @@ static void synaptics_process_packet(struct psmouse *psmouse)
>
>         if (hw.z > 0 && hw.x > 1) {
>                 num_fingers = 1;
> -               finger_width = 5;
> +               finger_width = 4;

I am not sure about this change. It looks benign, but I don't get how
changing the local variable finger_width can change anything in the
CR48 processing.

Except for this one (which could be dropped IMO), the *rest* of the series is:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

Thanks for pushing this Gabriele.

Cheers,
Benjamin

>                 if (SYN_CAP_EXTENDED(priv->capabilities)) {
>                         switch (hw.w) {
>                         case 0 ... 1:
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/