linux-kernel - Re: [PATCH] gpio: syscon: reduce message level when direction reg offset not in dt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Mar 2015 16:00:13 -0400
From:	Murali Karicheri <m-karicheri2@...com>
To:	<grygorii.strashko@...aro.org>
CC:	<linux@....linux.org.uk>, Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>, <ssantosh@...nel.org>,
	<linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: syscon: reduce message level when direction reg
 offset not in dt

On 03/24/2015 02:42 PM, grygorii.strashko@...aro.org wrote:
> From: Grygorii Strashko<grygorii.strashko@...aro.org>
>
> Now GPIO syscon driver produces bunch of warnings during the
> boot of Kesytone 2 SoCs:
>   gpio-syscon soc:keystone_dsp_gpio@...20240: can't read the dir register offset!
>   gpio-syscon soc:keystone_dsp_gpio@...0244: can't read the dir register offset!
>
> This message unintentionally was added using dev_err(), but its
> actual log level is debug, because third cell of "ti,syscon-dev" is
> optional.
>
> Hence change it to dev_dbg() as it should be.
>
> This patch fixes commit:
>   5a3e3f8 ("gpio: syscon: retriave syscon node and regs offsets from dt")
>
> Reported-by: Russell King<linux@....linux.org.uk>
> Signed-off-by: Grygorii Strashko<grygorii.strashko@...aro.org>
> ---
>   drivers/gpio/gpio-syscon.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c
> index 257e298..045a952 100644
> --- a/drivers/gpio/gpio-syscon.c
> +++ b/drivers/gpio/gpio-syscon.c
> @@ -219,7 +219,7 @@ static int syscon_gpio_probe(struct platform_device *pdev)
>   		ret = of_property_read_u32_index(np, "gpio,syscon-dev", 2,
>   						&priv->dir_reg_offset);
>   		if (ret)
> -			dev_err(dev, "can't read the dir register offset!\n");
> +			dev_dbg(dev, "can't read the dir register offset!\n");
>
>   		priv->dir_reg_offset<<= 3;
>   	}

Tested this on K2HK EVM and found the error log is not appearing any more.

Tested-by: Murali Karicheri <m-karicheri2@...com>

-- 
Murali Karicheri
Linux Kernel, Texas Instruments
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/