linux-kernel - Re: [PATCH 3/3] block: loop: use vfs ITER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVXFVPFg2kAYLA_y39QPRT8dCKiPq=tHc1synX9GhEs37tp1g@mail.gmail.com>
Date:	Tue, 24 Mar 2015 19:01:16 +0800
From:	Ming Lei <ming.lei@...onical.com>
To:	Christoph Hellwig <hch@....de>
Cc:	Jens Axboe <axboe@...com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Maxim Patlasov <mpatlasov@...allels.com>
Subject: Re: [PATCH 3/3] block: loop: use vfs ITER_BVEC to read/write backing file

On Tue, Mar 24, 2015 at 6:31 PM, Christoph Hellwig <hch@....de> wrote:
> On Sun, Mar 22, 2015 at 04:14:54PM +0800, Ming Lei wrote:
>> Now loop code gets simplified a lot, and becomes more clean.
>>
>> Also one extra page copy is avoided for READ in case of none
>> transfer.
>
> I really don't like the mess with the wrappers to pretent that read/write
> work the same,

Could you comment on code about the mess?

Actually this patch tried to move common things between read/write
out of read() and write() compared before.

> and the ibvec_rw_data structure doesn't exactly help
> readability either.

This can be removed if you think lots of parameters are better.

Thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/