linux-kernel - Re: [PATCH] Staging: slicoss: Fix checkpatch.pl issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Mar 2015 13:12:03 +0100
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Niranjan Dighe <niranjan.dighe@...il.com>
Cc:	liodot@...il.com, charrer@...critech.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: slicoss: Fix checkpatch.pl issues

On Wed, Mar 25, 2015 at 01:28:43AM +0530, Niranjan Dighe wrote:
> Removed unused block of code guarded by #ifdef SLIC_TRACE_DUMP_ENABLED
> And removed redundant static char *slic_banner and replaced actual string in
> place of format string.

That's multiple things you are doing all in the same patch, please break
this up into multiple patches and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/