linux-kernel - Re: [PATCH 61/86] scsi/qla1280: use uapi/linux/pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 29 Mar 2015 17:03:36 +0300
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Michael Reed <mdr@....com>,
	linux-scsi@...r.kernel.org
Subject: Re: [PATCH 61/86] scsi/qla1280: use uapi/linux/pci_ids.h directly

On Sun, 2015-03-29 at 15:42 +0200, Michael S. Tsirkin wrote:
> Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h,
> use the new header directly so we can drop
> the wrapper in include/linux/pci_ids.h.
> 
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> ---
>  drivers/scsi/qla1280.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
> index c68a66e..b2ada21 100644
> --- a/drivers/scsi/qla1280.c
> +++ b/drivers/scsi/qla1280.c
> @@ -348,7 +348,7 @@
>  #include <linux/pci.h>
>  #include <linux/proc_fs.h>
>  #include <linux/stat.h>
> -#include <linux/pci_ids.h>
> +#include <uapi/linux/pci_ids.h>

This is bogus, isn't it?  There's a -Iuapi somewhere in the kernel
compile line so the original include is still valid.  Zorro does this:
zorro_ids.h is exclusively in uapi but the include is still

#include <linux/zorro_ids.h>

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/