linux-kernel - Re: [PATCH] mtd: fsl_ifc_nand: use msecs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 1 Apr 2015 08:58:05 -0500 (CDT)
From:	Aaron Sierra <asierra@...-inc.com>
To:	Nicholas Mc Guire <hofrat@...dl.org>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	Joe Schultz <jschultz@...-inc.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: fsl_ifc_nand: use msecs_to_jiffies for time
 conversion

----- Original Message -----
> From: "Nicholas Mc Guire" <hofrat@...dl.org>
> Sent: Friday, March 13, 2015 6:23:47 AM
> 
> This is only an API consolidation and should make things more readable
> it replaces var * HZ / 1000 by msecs_to_jiffies(var) which helps readability
> and also handles all corner-cases properly.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> ---
> 
> Patch was compile tested with corenet64_smp_defconfig
> (implies CONFIG_MTD_NAND_FSL_IFC=y)
> 
> Patch is against 4.0-rc3 (localversion-next is -next-20150313
> 
>  drivers/mtd/nand/fsl_ifc_nand.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/fsl_ifc_nand.c
> b/drivers/mtd/nand/fsl_ifc_nand.c
> index 4c05f4f..51394e5 100644
> --- a/drivers/mtd/nand/fsl_ifc_nand.c
> +++ b/drivers/mtd/nand/fsl_ifc_nand.c
> @@ -317,7 +317,7 @@ static void fsl_ifc_run_command(struct mtd_info *mtd)
>  
>  	/* wait for command complete flag or timeout */
>  	wait_event_timeout(ctrl->nand_wait, ctrl->nand_stat,
> -			   IFC_TIMEOUT_MSECS * HZ/1000);
> +			   msecs_to_jiffies(IFC_TIMEOUT_MSECS));

Nicholas,
Your patch makes me think that this timeout value should be calculated
once during initialization and stored in a new member of
struct fsl_ifc_mtd. That would improve readability AND have some
positive impact on performance.

-Aaron S.

>  
>  	/* ctrl->nand_stat will be updated from IRQ context */
>  	if (!ctrl->nand_stat)
> @@ -860,7 +860,7 @@ static void fsl_ifc_sram_init(struct fsl_ifc_mtd *priv)
>  
>  	/* wait for command complete flag or timeout */
>  	wait_event_timeout(ctrl->nand_wait, ctrl->nand_stat,
> -			   IFC_TIMEOUT_MSECS * HZ/1000);
> +			   msecs_to_jiffies(IFC_TIMEOUT_MSECS));
>  
>  	if (ctrl->nand_stat != IFC_NAND_EVTER_STAT_OPC)
>  		printk(KERN_ERR "fsl-ifc: Failed to Initialise SRAM\n");
> --
> 1.7.10.4
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/