lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 31 Mar 2015 20:35:07 -0400 From: Jeff Layton <jlayton@...chiereds.net> To: Steve French <smfrench@...il.com> Cc: linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/4] [SMB3] Fix warning on uninitialized buftype On Fri, 27 Mar 2015 00:27:59 -0500 Steve French <smfrench@...il.com> wrote: > Pointed out by coverity analyzer. resp_buftype is > not initialized in one path which can rarely log > a spurious warning (buf is null so there will > not be a problem with freeing data, but if buf_type > were randomly set to wrong value could log a warning) > > Reported by Coverity (CID 1269144) > > Signed-off-by: Steve French <smfrench@...il.com> > --- > fs/cifs/smb2pdu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c > index 3417340..1b906de 100644 > --- a/fs/cifs/smb2pdu.c > +++ b/fs/cifs/smb2pdu.c > @@ -2114,7 +2114,7 @@ SMB2_query_directory(const unsigned int xid, struct cifs_tcon *tcon, > struct kvec iov[2]; > int rc = 0; > int len; > - int resp_buftype; > + int resp_buftype = CIFS_NO_BUFFER; > unsigned char *bufptr; > struct TCP_Server_Info *server; > struct cifs_ses *ses = tcon->ses; Reviewed-by: Jeff Layton <jlayton@...chiereds.net> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists