linux-kernel - RE: [PATCH net-next V3 13/23] ptp: igb: convert to the 64 bit get/set time methods.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Apr 2015 00:06:56 +0000
From:	"Keller, Jacob E" <jacob.e.keller@...el.com>
To:	Richard Cochran <richardcochran@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Amir Vadai <amirv@...lanox.com>,
	Ariel Elior <ariel.elior@...gic.com>,
	Arnd Bergmann <arnd@...aro.org>,
	Baolin Wang <baolin.wang@...aro.org>,
	Ben Hutchings <ben@...adent.org.uk>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Wyborny, Carolyn" <carolyn.wyborny@...el.com>,
	Chris Metcalf <cmetcalf@...hip.com>,
	David Miller <davem@...emloft.net>,
	Frank Li <Frank.Li@...escale.com>,
	Giuseppe Cavallaro <peppe.cavallaro@...com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	John Stultz <john.stultz@...aro.org>,
	"Luwei Zhou" <b45643@...escale.com>,
	"Vick, Matthew" <matthew.vick@...el.com>,
	Michael Chan <mchan@...adcom.com>,
	Prashant Sreedharan <prashant@...adcom.com>,
	Rayagond K <rayagond@...avyalabs.com>,
	Shradha Shah <sshah@...arflare.com>,
	Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
	Sonic Zhang <sonic.zhang@...log.com>,
	Stefan Sørensen 
	<stefan.sorensen@...ctralink.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Tom Lendacky <thomas.lendacky@....com>
Subject: RE: [PATCH net-next V3 13/23] ptp: igb: convert to the 64 bit
 get/set time methods.



> -----Original Message-----
> From: Richard Cochran [mailto:richardcochran@...il.com]
> Sent: Tuesday, March 31, 2015 2:53 PM
> To: netdev@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org; Amir Vadai; Ariel Elior; Arnd Bergmann;
> Baolin Wang; Ben Hutchings; Allan, Bruce W; Wyborny, Carolyn; Chris
> Metcalf; David Miller; Frank Li; Giuseppe Cavallaro; Keller, Jacob E; Kirsher,
> Jeffrey T; John Stultz; Luwei Zhou; Vick, Matthew; Michael Chan; Prashant
> Sreedharan; Rayagond K; Shradha Shah; Solarflare linux maintainers; Sonic
> Zhang; Stefan Sørensen; Thomas Gleixner; Tom Lendacky
> Subject: Re: [PATCH net-next V3 13/23] ptp: igb: convert to the 64 bit
> get/set time methods.
> 
> On Sun, Mar 29, 2015 at 11:12:03PM +0200, Richard Cochran wrote:
> 
> > @@ -627,11 +628,11 @@ static void igb_ptp_overflow_check(struct
> work_struct *work)
> >  {
> >  	struct igb_adapter *igb =
> >  		container_of(work, struct igb_adapter,
> ptp_overflow_work.work);
> > -	struct timespec ts;
> > +	struct timespec64 ts;
> >
> > -	igb->ptp_caps.gettime(&igb->ptp_caps, &ts);
> > +	igb->ptp_caps.gettime64(&igb->ptp_caps, &ts);
> >
> > -	pr_debug("igb overflow check at %ld.%09lu\n", ts.tv_sec,
> ts.tv_nsec);
> > +	pr_debug("igb overflow check at %lld.%09lu\n", ts.tv_sec,
> ts.tv_nsec);
> 
> For a 64 bit build, this produces the same warning as e1000e.
> 
> What is the best way to deal with this warning?
> 
> Thanks,
> Richard

I don't know how kernel would fix this. Usually macros like PRI64d are used but I am not sure those are defined for the kernel builds

Regards,
Jake
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/